Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (955aaa0) to head (382b39d).

@@            Coverage Diff            @@
##              main      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2911      2910    -1     
  Branches       343       341    -2     
=========================================
- Hits          2911      2910    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Surprising that now OctKey dumps the secret with private=False

>>> from joserfc.jwk import OctKey
>>> key = OctKey.import_key("foobar")
>>> key.as_dict(private=False)
{'k': 'Zm9vYmFy', 'kty': 'oct'}
>>> key.as_dict(private=True)
{'k': 'Zm9vYmFy', 'kty': 'oct'}

It is a voluntary change?

For OctKey, there is no private or public.

Yes, I was just noticing this because the original issue intent is to not leak secrets by default when calling as_dict.
LGTM anyway.